Re: [PATCH 8139too] Dreamcast Broad Band Adaptor support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sunday 22 July 2001 20:57, NIIBE Yutaka wrote:
> Hi,
>
> Here's a patch to support SEGA Broad Band Adaptor with 8139too driver.
> SEGA Broad Band Adapter is the network interface for Dreamcast.

Cute.

> diff -ruNp v2.4.7/Documentation/Configure.help
> linux/Documentation/Configure.help ---
> v2.4.7/Documentation/Configure.help	Fri Jul 20 09:48:15 2001
> +++ linux/Documentation/Configure.help	Mon Jul 23 09:33:58 2001
> @@ -8748,6 +8748,12 @@ CONFIG_8139TOO_8129
>    of an internal one.  Disabling this option will save some memory
>    by making the code size smaller.  If unsure, say Y.
>
> +Support for Dreamcast Broad Band Adaptor
> +CONFIG_8139TOO_DREAMCAST
> +  This enables support for the SEGA Broad Band Adaptor for Dreamcast.
> +  It uses 16KB buffer and doesn't support mapping main memory to DMA.
> +  If unsure, say N.
> +
>  SiS 900 PCI Fast Ethernet Adapter support
>  CONFIG_SIS900
>    This is a driver for the Fast Ethernet PCI network cards based on

This does not seem right to me. Sure, it draws attention to the fact that we 
now have Ethernet support for Dreamcast. However, we already have 3
suboptions for the 8139too driver. If every driver had that many options it 
would be even more a PITA to configure the kernel than it currently is. I 
think we should rather _reduce_ the number of options to what's really 
necessary. In your case: Doesn't your architecture define some symbol we 
could use to compile the driver correctly automagically?

Jeff, wouldn't it be better so simply _always_ compile in tune_twister and 
8129 support? How much would that hurt performance?

  -- Jens
-
: send the line "unsubscribe linux-net" in
the body of a message to majordomo@vger.kernel.org


[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux 802.1Q VLAN]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Git]     [Bugtraq]     [Yosemite News and Information]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux PCI]     [Linux Admin]     [Samba]

  Powered by Linux