kuznet@ms2.inr.ac.ru wrote: > > Hello! > > > Documentation/networking/netdevices.txt says that netdev->get_stats() is > > protected by the dev_base_lock spinlock, > > dev_base_lock is not spinlock, but rw lock. > > Acceses to method get_stats are _not_ mutually exclusive in any case, > which is natural for this method. If device needs exclusive access, > it is its problem to provide it, f.e. devices which update > heir stats from hardware while get_stats use their nternal controller > irq-safe spinlock. > > Alexey Ok, how about a patch to the docs like this? --- linux/Documentation/networking/netdevices.txt.orig Wed May 16 16:01:15 2001+++ linux/Documentation/networking/netdevices.txt Wed May 16 16:41:22 2001 @@ -24,7 +24,7 @@ Sleeping: OK dev->get_stats: - Locking: Inside dev_base_lock spinlock. + Locking: Inside dev_base_lock read/write lock. Not exculsive. Sleeping: NO dev->hard_start_xmit: - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org
