and you don't get the "RTNL: assertion failed at devinet.c(775):inetdev_event" in 2.4.x ? the thing is I need to prevent Tx/Rx when a topology change is initiated from the ioctl (registering a virtual adapter is just one example), so they all share a single lock and I must use spin_lock_bh from the ioctl. Shmulik. -----Original Message----- From: Olaf Titz [mailto:olaf@bigred.inka.de] Sent: Friday, November 10, 2000 2:09 AM To: linux-kernel@vger.kernel.org Subject: Re: catch 22 - porting net driver from 2.2 to 2.4 > We figured that since we are in user context (do_ioctl) and use > spin_lock_bh() to protect us from other concurrent threads, it might > interfere with rtnl_lock() so we remove our lock just before calling > register_netdev() and lock again upon return but then the whole process just > stopped and didn't return to the prompt. from within kdb, we could see that Can't you just do this: #if LINUX_VERSION_CODE >= KERNEL_VERSION(2,3,0) /* not sure about the 0 */ #define rtnl_LOCK() rtnl_lock() #define rtnl_UNLOCK() rtnl_unlock() #else #define rtnl_LOCK() /* nop */ #define rtnl_UNLOCK() /* nop */ #endif rtnl_LOCK(); register_netdevice(...); rtnl_UNLOCK(); that works for me (yes, from do_ioctl, but without the bh lock - I don't know if that's absolutely needed in your case). Olaf - : send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org Please read the FAQ at http://www.tux.org/lkml/ - : send the line "unsubscribe linux-net" in the body of a message to majordomo@vger.kernel.org
