Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Wed, 3 Jun 2020 15:49:16 +0200: > This simplifies the init() error path and the remove() handler. > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> > --- > drivers/mtd/nand/raw/fsl_upm.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/mtd/nand/raw/fsl_upm.c b/drivers/mtd/nand/raw/fsl_upm.c > index 9cf79c62ef22..a3e3a968891d 100644 > --- a/drivers/mtd/nand/raw/fsl_upm.c > +++ b/drivers/mtd/nand/raw/fsl_upm.c > @@ -176,8 +176,9 @@ static int fun_chip_init(struct fsl_upm_nand *fun, > return -ENODEV; > > nand_set_flash_node(&fun->chip, flash_np); > - mtd->name = kasprintf(GFP_KERNEL, "0x%llx.%pOFn", (u64)io_res->start, > - flash_np); > + mtd->name = devm_kasprintf(fun->dev, GFP_KERNEL, "0x%llx.%pOFn", > + (u64)io_res->start, > + flash_np); Shouldn't we check if mtd->name was not already set by nand_set_flash_node() first? ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/