Re: [1/2] ubifs: Fix potential memory leaks while iterating entries

[Markus Elfring <Markus.Elfring@xxxxxx>]

>> I suggest to avoid the specification of duplicate function calls
>> (also for the desired exception handling).
>> Will it be helpful to add a few jump targets?
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=3d77e6a8804abcc0504c904bd6e5cdf3a5cf8162#n455
> I've thought about using "goto err_tag_2" in kill_xattrs code block to release prev xent,

I propose to choose better labels.


> but later it needs to jump to 'out_release tag‘ for releasing previously requested memory,
> which can clutter the code.

Would you like to reconsider this view?


> It seems that two consecutive 'goto tags' will make the code less readable.

How do you think about to try another software adjustment out in such a design direction?


Can it make sense to combine changes together with the update step
“ubifs: dent: Fix some potential memory leaks while iterating entries”
into a single patch?
https://lore.kernel.org/linux-mtd/20200601091037.3794172-2-chengzhihao1@xxxxxxxxxx/
https://lore.kernel.org/patchwork/patch/1250456/

Regards,
Markus

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/