Re: [PATCH v7 28/28] mtd: rawnand: Allocate the interface configurations dynamically

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Fri, 29 May
2020 13:49:10 +0200:

> On Fri, 29 May 2020 13:43:54 +0200
> Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> 
> > Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Fri, 29 May
> > 2020 13:41:05 +0200:
> >   
> > > On Fri, 29 May 2020 13:37:04 +0200
> > > Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote:
> > >     
> > > > > +/* Default/reset data interface */
> > > > > +const struct nand_interface_config *nand_get_reset_interface(void);        
> > > > 
> > > > nand_get_reset_interface_config(), and I'm not sure you need to
> > > > expose that one. I'd expect it to be used only by the core.      
> > > 
> > > Just to be clear, I mean it should be defined in internal.h, not
> > > rawnand.h.    
> > 
> > That's true, I'll change it.  
> 
> Once fixed you can add
> 
> Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> 
> and the series should be good to go.
> 
> Thanks for baring with me and my annoying comments :P.

\ooooo/

:-D

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/