Re: [PATCH v6 17/30] mtd: rawnand: s/data_interface/interface_config/

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Hi Boris,

Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Fri, 29 May
2020 10:11:07 +0200:

> On Fri, 29 May 2020 09:47:55 +0200
> Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote:
> 
> > On Fri, 29 May 2020 01:15:59 +0200
> > Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> >   
> > > From: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> > > 
> > > The name/suffix data_interface is a bit misleading in that the field
> > > or functions actually represent a configuration that can be applied by
> > > the controller/chip. Let's rename all fields/functions/hooks that are
> > > worth renaming.
> > > 
> > > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> > > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>    
> > 
> > I know it's painful to move that one, but I think it should be at the
> > beginning of the series so the functions/fields you introduce have the
> > right name from the start.  
> 
> Hm, maybe I'm wrong and you don't introduce any new interface-related
> functions/fields before that one.


Indeed, I don't introduce new hooks before this patch. What I do is
renaming a few fields, but honestly, before of after, the
s/data_interface/interface_config/ applies anyway.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/