Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Thu, 28 May 2020 16:42:17 +0200: > On Thu, 28 May 2020 13:31:12 +0200 > Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote: > > > +static enum nand_ecc_engine_type > > +of_get_rawnand_ecc_engine_type_legacy(struct device_node *np) > > +{ > > + enum nand_ecc_legacy_mode { > > + NAND_ECC_INVALID, > > + NAND_ECC_NONE, > > + NAND_ECC_SOFT, > > + NAND_ECC_SOFT_BCH, > > + NAND_ECC_HW, > > + NAND_ECC_HW_SYNDROME, > > + NAND_ECC_ON_DIE, > > + }; > > You're redefining an enum, but I don't see the old enum/defines being > removed, is that expected? Oh yeah, my desire was to get rid of this public enumeration and mov it to the single legacy function using it, but indeed I am removing it in the next patch as part of the global move to nand/core.c. I will do it in this patch. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/