Re: [PATCH v2 00/17] Clean nandsim error path

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote on Mon, 25 May 2020
10:52:10 +0200:

> Hello,
> 
> As part of a bigger cleanup I realized the error path of nandsim.c was
> horribly wrong. There are a few additional changes, like having a
> consistent naming for a given object, but moreover this is an error
> path cleanup, driver-wide.

Wrong operation on my side, I was about to send 90 patches so I
canceled the operation.

I will resend, sorry for the noise.

> 
> Cheers,
> Miquèl
> 
> Changes in v2:
> * Reordered the kfree() and the list_del() to avoid a use after free
>   issue that I introduced in v1.
> * Used debugfs_remove_recursive() instead of just debugfs_remove().
> 
> Miquel Raynal (17):
>   mtd: rawnand: nandsim: Consistent use of 'ns' instead of 'dev'
>   mtd: rawnand: nandsim: Use octal permissions
>   mtd: rawnand: nandsim: Use a consistent ns_ prefix for all functions
>   mtd: rawnand: nandsim: Clean error handling
>   mtd: rawnand: nandsim: Keep track of the created debugfs entries
>   mtd: rawnand: nandsim: Remove debugfs entries at unload time
>   mtd: rawnand: nandsim: Fix the two ns_alloc_device() error paths
>   mtd: rawnand: nandsim: Free partition names on error in ns_init()
>   mtd: rawnand: nandsim: Free the allocated device on error in ns_init()
>   mtd: rawnand: nandsim: Free the partition names in ns_free()
>   mtd: rawnand: nandsim: Stop using nand_release()
>   mtd: rawnand: nandsim: Use an additional label when freeing the
>     nandsim object
>   mtd: rawnand: nandsim: Free erase_block_wear on error
>   mtd: rawnand: nandsim: Fix the label pointing on nand_cleanup()
>   mtd: rawnand: nandsim: Manage lists on error in ns_init_module()
>   mtd: rawnand: nandsim: Rename a label in ns_init_module()
>   mtd: rawnand: nandsim: Reorganize ns_cleanup_module()
> 
>  drivers/mtd/nand/raw/nandsim.c | 437 +++++++++++++++++++--------------
>  1 file changed, 253 insertions(+), 184 deletions(-)
> 


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/