Re: [PATCH 06/17] mtd: rawnand: nandsim: Remove debugfs entries at unload time

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Hi Richard,

Richard Weinberger <richard.weinberger@xxxxxxxxx> wrote on Sun, 24 May
2020 23:33:06 +0200:

> On Sat, May 9, 2020 at 9:16 PM Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> >
> > Create a ns_debugfs_remove() helper for that and call it in
> > ns_cleanup_module().
> >
> > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> > ---
> >  drivers/mtd/nand/raw/nandsim.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/mtd/nand/raw/nandsim.c b/drivers/mtd/nand/raw/nandsim.c
> > index c8e9c70a6641..7862c65e32ad 100644
> > --- a/drivers/mtd/nand/raw/nandsim.c
> > +++ b/drivers/mtd/nand/raw/nandsim.c
> > @@ -520,6 +520,11 @@ static int ns_debugfs_create(struct nandsim *ns)
> >         return 0;
> >  }
> >
> > +static void ns_debugfs_remove(struct nandsim *ns)
> > +{
> > +       debugfs_remove(ns->dent);  
> 
> BTW: For now it is perfectly fine, but later this can be a
> debugfs_remove_recursive().

Ok, I'll use it in the v2!

> 
> > +}
> > +
> >  /*
> >   * Allocate array of page pointers, create slab allocation for an array
> >   * and initialize the array by NULL pointers.
> > @@ -2398,6 +2403,7 @@ static void __exit ns_cleanup_module(void)
> >         struct nandsim *ns = nand_get_controller_data(chip);
> >         int i;
> >
> > +       ns_debugfs_remove(ns);
> >         ns_free(ns);    /* Free nandsim private resources */
> >         nand_release(chip); /* Unregister driver */
> >         for (i = 0;i < ARRAY_SIZE(ns->partitions); ++i)
> > --
> > 2.20.1
> >
> >
> > ______________________________________________________
> > Linux MTD discussion mailing list
> > http://lists.infradead.org/mailman/listinfo/linux-mtd/  
> 
> 
> 




Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/