Re: [PATCH 06/17] mtd: rawnand: nandsim: Remove debugfs entries at unload time

[Richard Weinberger <richard.weinberger@xxxxxxxxx>]

On Sun, May 10, 2020 at 12:30 AM Miquel Raynal
<miquel.raynal@xxxxxxxxxxx> wrote:
>
> Hi Richard,
>
> Richard Weinberger <richard@xxxxxx> wrote on Sat, 9 May 2020 22:43:00
> +0200 (CEST):
>
> > ----- Ursprüngliche Mail -----
> > > Von: "Miquel Raynal" <miquel.raynal@xxxxxxxxxxx>
> > > An: "richard" <richard@xxxxxx>, "Vignesh Raghavendra" <vigneshr@xxxxxx>, "Tudor Ambarus" <Tudor.Ambarus@xxxxxxxxxxxxx>,
> > > "linux-mtd" <linux-mtd@xxxxxxxxxxxxxxxxxxx>
> > > CC: "Boris Brezillon" <boris.brezillon@xxxxxxxxxxxxx>, dedekind@xxxxxxxxxxxxx, "Miquel Raynal"
> > > <miquel.raynal@xxxxxxxxxxx>
> > > Gesendet: Samstag, 9. Mai 2020 21:14:19
> > > Betreff: [PATCH 06/17] mtd: rawnand: nandsim: Remove debugfs entries at unload time
> >
> > > Create a ns_debugfs_remove() helper for that and call it in
> > > ns_cleanup_module().
> > >
> > > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> > > ---
> > > drivers/mtd/nand/raw/nandsim.c | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/drivers/mtd/nand/raw/nandsim.c b/drivers/mtd/nand/raw/nandsim.c
> > > index c8e9c70a6641..7862c65e32ad 100644
> > > --- a/drivers/mtd/nand/raw/nandsim.c
> > > +++ b/drivers/mtd/nand/raw/nandsim.c
> > > @@ -520,6 +520,11 @@ static int ns_debugfs_create(struct nandsim *ns)
> > >     return 0;
> > > }
> > >
> > > +static void ns_debugfs_remove(struct nandsim *ns)
> > > +{
> > > +   debugfs_remove(ns->dent);
> > > +}
> > > +
> > > /*
> > >  * Allocate array of page pointers, create slab allocation for an array
> > >  * and initialize the array by NULL pointers.
> > > @@ -2398,6 +2403,7 @@ static void __exit ns_cleanup_module(void)
> > >     struct nandsim *ns = nand_get_controller_data(chip);
> > >     int i;
> > >
> > > +   ns_debugfs_remove(ns);
> > >     ns_free(ns);    /* Free nandsim private resources */
> >
> > Why is this special and cannot done in ns_free()?
> >
>
> ns_debugfs_create() is called in ns_init_module(), so for me it is
> natural to call ns_debugfs_remove in ns_cleanup_module(). More than
> calling it from ns_free() which is the symmetry of ns_init(). No?

Okay. Makes sense.

-- 
Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/