Re: [PATCH] ubifs: fix wrong use of crypto_shash_descsize()

[Eric Biggers <ebiggers@xxxxxxxxxx>]

On Mon, May 04, 2020 at 09:16:44AM +0200, Sascha Hauer wrote:
> On Fri, May 01, 2020 at 10:59:45PM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@xxxxxxxxxx>
> > 
> > crypto_shash_descsize() returns the size of the shash_desc context
> > needed to compute the hash, not the size of the hash itself.
> > 
> > crypto_shash_digestsize() would be correct, or alternatively using
> > c->hash_len and c->hmac_desc_len which already store the correct values.
> > But actually it's simpler to just use stack arrays, so do that instead.
> > 
> > Fixes: 49525e5eecca ("ubifs: Add helper functions for authentication support")
> > Fixes: da8ef65f9573 ("ubifs: Authenticate replayed journal")
> > Cc: <stable@xxxxxxxxxxxxxxx> # v4.20+
> > Cc: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> Looks better that way, thanks.
> 
> Acked-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
> 

Richard, could you take this through the ubifs tree for 5.8?

- Eric

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/