Re: [PATCH 1/2] ARM: pxa: remove Compulab pxa2xx boards

[Arnd Bergmann <arnd@xxxxxxxx>]

On Wed, May 13, 2020 at 7:01 PM Robert Jarzmik <robert.jarzmik@xxxxxxx> wrote:
>
> As these boards have no more users nor testers, and patching them has
> become a burden, be that because of the PCI part or the MTD NAND
> support, let's remove them.
>
> The cm-x300 will for now remain and represent Compulab boards at its
> best in the PXA department.
>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@xxxxxxx>

Thanks for taking care of this!

I went through the patch looking for additional code that has become obsolete:

> diff --git a/arch/arm/configs/pxa_defconfig b/arch/arm/configs/pxa_defconfig
> index b817c57f05f1..e6559e3350e6 100644
> --- a/arch/arm/configs/pxa_defconfig
> +++ b/arch/arm/configs/pxa_defconfig
> @@ -38,8 +38,6 @@ CONFIG_MACH_ARCOM_ZEUS=y
>  CONFIG_MACH_BALLOON3=y
>  CONFIG_MACH_CSB726=y
>  CONFIG_CSB726_CSB701=y
> -CONFIG_MACH_ARMCORE=y
> -CONFIG_MACH_EM_X270=y
>  CONFIG_MACH_EXEDA=y

CONFIG_MACH_EXEDA should be removed here as well, it refers
to part of em-x270.c

Similarly, the whole em_x270_defconfig can be removed.

> diff --git a/arch/arm/mach-pxa/Kconfig b/arch/arm/mach-pxa/Kconfig
> index f60bc29aef68..8931a2424676 100644
> --- a/arch/arm/mach-pxa/Kconfig
> +++ b/arch/arm/mach-pxa/Kconfig
> @@ -123,19 +123,6 @@ config CSB726_CSB701
>         bool "Enable support for CSB701 baseboard"
>         depends on MACH_CSB726
>
> -config MACH_ARMCORE
> -       bool "CompuLab CM-X255/CM-X270 modules"
> -       select ARCH_HAS_DMA_SET_COHERENT_MASK if PCI
> -       select IWMMXT
> -       select HAVE_PCI
> -       select NEED_MACH_IO_H if PCI

Now arch/arm/mach-pxa/include/mach/io.h is unused and
can be removed.

With MACH_ARMCORE gone, the MTD_NAND_CM_X270 and
PCI_HOST_ITE8152 become impossible to select, and
a part of PCMCIA_PXA2XX (pxa2xx_cm_x2xx_cs.c) becomes
unused.

FB_MBX can still be selected, but there are no boards defining
the platform data any more, so I'd like to remove that as well.

> -       select PXA25x
> -       select PXA27x
> -
> -config MACH_EM_X270
> -       bool "CompuLab EM-x270 platform"
> -       select PXA27x
> -
>  config MACH_EXEDA
>         bool "CompuLab eXeda platform"
>         select PXA27x

MACH_EXEDA here is also obsolete, and I'd probably want to
update the SND_PXA2XX_SOC_EM_X270 dependencies in the
same patch.

It would make sense to rename it in theory, but it's probably
easier to leave it as it is aside from the dependency.

> -static struct spi_board_info spi_board_info[] __initdata = {
> -       [0] = {
> -               .modalias       = "rtc-max6902",
> -               .max_speed_hz   = 1000000,
> -               .bus_num        = 1,
> -               .chip_select    = 0,

Another last reference, so we can remove that the corresponding driver.

> -static struct platform_device cmx270_rtc_device = {
> -       .name           = "v3020",
> -       .num_resources  = ARRAY_SIZE(cmx270_v3020_resource),
> -       .resource       = cmx270_v3020_resource,
> -       .id             = -1,
> -       .dev            = {
> -               .platform_data = &cmx270_v3020_pdata,
> -       }
> -};

This is now only used in cm-x300, so it has to stay for now.

> -static struct spi_board_info cm_x270_spi_devices[] __initdata = {
> -       {
> -               .modalias               = "libertas_spi",
>-               .max_speed_hz           = 13000000,

Same here, there is still one more user left (MACH_ZIPIT2), though
at some point that might get removed if we decide to drop the handhelds
with 32MB RAM or less.  That is probably something to be left for
another time, but I see that pxa_defconfig produces a 9.5MB kernel
image, so this is getting rather tight, and 32MB wasn't much when this
got added in 2010.

       Arnd

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/