Re: [PATCH] mtd: rawnand: fsmc: Change to non-atomic bit operations

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

On Sat, 2019-12-21 at 00:05:55 UTC, Fenghua Yu wrote:
> No need to use expensive atomic change_bit() on dat[] and err_idx[]:
> 1. fsmc_bch8_correct_data() is called while mutex chip->lock is held
> 2. err_idx[] is a local variable.
> 
> To avoid big endian concern due to type cast to unsigned long, directly
> change the bit in the specified byte instead of using non-atomic
> __change_bit().
> 
> Suggested-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/