Re: [PATCH] mtd: physmap_of_gemini: remove defined but not used symbol 'syscon_match'

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Mon, Apr 27, 2020 at 3:53 PM Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
> Jason Yan <yanaijie@xxxxxxxxxx> wrote on Fri, 3 Apr 2020 16:15:44 +0800:
>
> > It's not used by anyone now, remove it. Fix the following gcc warning:
> >
> > drivers/mtd/maps/physmap-gemini.c:49:34: warning: ‘syscon_match’ defined
> > but not used [-Wunused-const-variable=]
> >  static const struct of_device_id syscon_match[] = {
> >                                   ^~~~~~~~~~~~
> >
> > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> > Signed-off-by: Jason Yan <yanaijie@xxxxxxxxxx>
> > ---
>
> I am not sure this is the right solution. This compatible has been
> added in this driver by Linus in 9d3b5086f6d4 ("mtd: physmap_of_gemini:
> Handle pin control"). I believe he had a good reason to do so but you
> are right that it is not used. Linus, any input?

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

It's probably just a remnant of earlier development, sorry for that.
We now locate the syscon by phandle:
rmap = syscon_regmap_lookup_by_phandle(np, "syscon");

Yours,
Linus Walleij

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/