Re: [PATCH 09/17] mtd: rawnand: cafe: Get rid of a useless label

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Hi Boris,

Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Mon, 27 Apr
2020 10:20:19 +0200:

> We can return 0 directly instead of branching to the out label.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> ---
>  drivers/mtd/nand/raw/cafe_nand.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/cafe_nand.c b/drivers/mtd/nand/raw/cafe_nand.c
> index 3eab57e63215..348debbc04af 100644
> --- a/drivers/mtd/nand/raw/cafe_nand.c
> +++ b/drivers/mtd/nand/raw/cafe_nand.c
> @@ -932,7 +932,7 @@ static int cafe_nand_probe(struct pci_dev *pdev,
>  	if (err)
>  		goto out_cleanup_nand;
>  
> -	goto out;
> +	return 0;
>  
>   out_cleanup_nand:
>  	nand_cleanup(&cafe->nand);
> @@ -943,7 +943,6 @@ static int cafe_nand_probe(struct pci_dev *pdev,
>  		    GLOBAL_IRQ_MASK);
>   out_ior:
>  	pci_iounmap(pdev, cafe->mmio);
> - out:
>  	return err;
>  }
>  


Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>


Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/