Re: [PATCH 04/17] mtd: rawnand: cafe: Include linux/io.h instead of asm/io.h

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Hi Boris,

Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx> wrote on Mon, 27 Apr
2020 10:20:14 +0200:

> Drivers should include the asm headers directly.

                not ?

> Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>

With this changed,

Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>

> ---
>  drivers/mtd/nand/raw/cafe_nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/cafe_nand.c b/drivers/mtd/nand/raw/cafe_nand.c
> index 47aacfab8ecb..156a308b530b 100644
> --- a/drivers/mtd/nand/raw/cafe_nand.c
> +++ b/drivers/mtd/nand/raw/cafe_nand.c
> @@ -23,7 +23,7 @@
>  #include <linux/dma-mapping.h>
>  #include <linux/slab.h>
>  #include <linux/module.h>
> -#include <asm/io.h>
> +#include <linux/io.h>
>  
>  #define CAFE_NAND_CTRL1		0x00
>  #define CAFE_NAND_CTRL2		0x04

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/