Re: [PATCH 3/3] mtd: lpddr: Move function print_drs_error to lpddr_cmds.c

["Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx>]

On 4/27/20 14:03, Joe Perches wrote:
> On Mon, 2020-04-27 at 14:04 -0500, Gustavo A. R. Silva wrote:
>> Function print_drs_error is only used in drivers/mtd/lpddr/lpddr_cmds.c
>> so, better to move it there.
> []
>> diff --git a/drivers/mtd/lpddr/lpddr_cmds.c b/drivers/mtd/lpddr/lpddr_cmds.c
> []
>> @@ -94,6 +94,39 @@ struct mtd_info *lpddr_cmdset(struct map_info *map)
>>  }
>>  EXPORT_SYMBOL(lpddr_cmdset);
>>  
>> +static inline void print_drs_error(unsigned int dsr)
> 
> There's no need for inline as it's used once.
> 

That's correct. I didn't notice that at first sight.

I'll remove it in V2.

Thanks
--
Gustavo

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/