Re: [PATCH 2/8] mtd: rawnand: timings: Fix default tR_max and tCCS_min timings

[Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>]

On Tue, 21 Apr 2020 18:46:31 +0200
Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:

> These values are hardcoded, there was no need to try to convert them
> in picoseconds, better write the right values in picoseconds directly.

Hm I had a hard time understanding what was wrong and whether this fix
was correct or not. Maybe you should just say that tR and tCCS are
currently wrongly expressed in femto seconds and this is restoring it
to pico seconds.

Other than that, this diff looks good.

Reviewed-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>

> 
> Fixes: 6a943386ee36 mtd: rawnand: add default values for dynamic timings
> Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx>
> ---
>  drivers/mtd/nand/raw/nand_timings.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/nand_timings.c b/drivers/mtd/nand/raw/nand_timings.c
> index 0061cbaf931d..36d21be3dfe5 100644
> --- a/drivers/mtd/nand/raw/nand_timings.c
> +++ b/drivers/mtd/nand/raw/nand_timings.c
> @@ -320,10 +320,9 @@ int onfi_fill_data_interface(struct nand_chip *chip,
>  		/* microseconds -> picoseconds */
>  		timings->tPROG_max = 1000000ULL * ONFI_DYN_TIMING_MAX;
>  		timings->tBERS_max = 1000000ULL * ONFI_DYN_TIMING_MAX;
> -		timings->tR_max = 1000000ULL * 200000000ULL;
>  
> -		/* nanoseconds -> picoseconds */
> -		timings->tCCS_min = 1000UL * 500000;
> +		timings->tR_max = 200000000;
> +		timings->tCCS_min = 500000;
>  	}
>  
>  	return 0;


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/