Re: [PATCH v2] mtd: spi-nor: Add support for s25fs128s

[<Tudor.Ambarus@xxxxxxxxxxxxx>]

On Wednesday, April 15, 2020 11:30:33 AM EEST Yicong Yang wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> Add support for Cypress s25fs128s flash. Previously the flash is
> decoded as s25fl129p1 by mistake.
> 
> Add it in the flash info list to correctly decode. No functional
> changes. Further capability of the flash will be parsed from bfpt.
> 
> Signed-off-by: Yicong Yang <yangyicong@xxxxxxxxxxxxx>
> ---
> Change since v1:
> - rebase the patch on v5.7 rc1
> 
>  drivers/mtd/spi-nor/spansion.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/spansion.c b/drivers/mtd/spi-nor/spansion.c
> index 6756202..01640c1 100644
> --- a/drivers/mtd/spi-nor/spansion.c
> +++ b/drivers/mtd/spi-nor/spansion.c
> @@ -29,6 +29,8 @@ static const struct flash_info spansion_parts[] = {
>         { "s25fl512s",  INFO6(0x010220, 0x4d0080, 256 * 1024, 256,
>                               SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
>                               SPI_NOR_HAS_LOCK | USE_CLSR) },
> +       { "s25fs128s",  INFO6(0x012018, 0x4d0181, 64 * 1024, 256,
> +               SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },

The flash should be named "s25fs128s1" - this would be the flavor with uniform 
64kB sectors. One should add a "s25fs128s0" entry for the flavor with uniform 
256kB sectors.

We usually don't add new flashes if they are not tested. Please specify in the 
commit message with which controller you tested the flash. The minimal test is 
a read, erase, read back, write and read back. This sequence should verify if 
read, erase and pp work fine.

Cheers,
ta


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/