Re: [PATCH v2] mtd: Convert fallthrough comments into statements

[<Tudor.Ambarus@xxxxxxxxxxxxx>]

On Friday, March 27, 2020 10:53:23 AM EET Miquel Raynal wrote:
> <Tudor.Ambarus@xxxxxxxxxxxxx> wrote on Fri, 27 Mar 2020 08:43:52 +0000:
> > On Wednesday, March 25, 2020 11:21:15 PM EET Miquel Raynal wrote:
> > > --- a/drivers/mtd/spi-nor/sfdp.c
> > > +++ b/drivers/mtd/spi-nor/sfdp.c
> > > @@ -623,7 +623,6 @@ static u8 spi_nor_smpt_addr_width(const struct
> > > spi_nor
> > > *nor, const u32 settings) case SMPT_CMD_ADDRESS_LEN_4:
> > > return 4;
> > > case SMPT_CMD_ADDRESS_LEN_USE_CURRENT:
> > > -               /* fall through */
> > 
> > just noticed that you forgot the statement here.
> > 
> > > default:
> > > return nor->addr_width;
> > > }
> 
> I think this one is not needed, you don't need a fallthrough statement
> when there are multiples case statements in a raw (default might be
> seen as a case statement). So it was removed on purpose.

You're right, that's ok.

Cheers,
ta



______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/