Re: [PATCH 1/1] mtd: add | as a separator after mtd-id

[ron minnich <rminnich@xxxxxxxxx>]

I agree with you on changing the PCI driver name, as opposed to this
change. I don't like '|' very much either.

I am thinking just to change ':' to '.', e.g.
0000:00:1f.3 -> 0000.00.1f.3

It is an extremely simple change --  add one for loop in the pci map
code -- and nothing else need change.

If this sounds good to you, I'll send a new 2-patch series with that
change and with the intel-spi driver changed to show how one can use
command line partitioning?

Also, as I am coming back to this after a very long time, how do you
like your patch series to look? It seems the git command to generate
these creates 3 files, the first numbered 0 with no code in it. My
reading of the docs implies sending this no-code email is not a good
idea? Any recommendations here?

thanks very much for your comment!

ron

On Sun, Mar 22, 2020 at 4:09 AM Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
>
> Hi Ronald,
>
> ron minnich <rminnich@xxxxxxxxx> wrote on Sat, 21 Mar 2020 08:44:07
> -0700:
>
> > Anyone? This will be going into use at Google internally and I'd like
> > to get it upstream.
> >
> > The only other option that would work is to take the pci-format names
> > created by intel-spi-pci that have : in them and change the : to '.'.
> > Is that more acceptable?
>
> One important thing to note: Bootloaders share the same mtdparts
> definition and should be updated if we decide to support a new
> separator. U-boot and Barebox at least.
>
> I think changing just Intel's PCI driver name would be much more
> practical for us because I don't find the '|' separator being
> descriptive at all.
>
> However, I don't have a strong position and I would welcome
> Richard, Vignesh, Tudor and Boris' point of view.
>
> Thanks,
> Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/