Re: [PATCH v3] mtd: spi-nor: Fixup page size for S25FS-S

[Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>]

Hello all,

On 24/02/2020 09:47, Alexander A Sverdlin wrote:
> Spansion S25FS-S family has an issue in Basic Flash Parameter Table:
> DWORD-11 bits 7-4 specify write page size 512 bytes. In reality this
> is configurable in the non-volatile CR3NV register and even factory
> default configuration is "wrap at 256 bytes". So blind relying on BFPT
> breaks write operation on these Flashes.
> 
> All this story is vendor-specific, so add the corresponding fixup hook
> which first restores the safe page size of 256 bytes from
> struct flash_info but checks is more performant 512 bytes configuration
> is active and adjusts the page_size accordingly.
> 
> Fixes: f384b352c ("mtd: spi-nor: parse Serial Flash Discoverable Parameters (SFDP) tables")
> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx>
> Change-Id: I998829dfe43a6778ac439a693f5f41670acd20f1

[...]

> +	ret = spi_nor_read_data(nor, SPINOR_REG_CR3V, 1, &buf);
> +	if (!ret && (buf & CR3V_02H_V))

please ignore this patch! Besides forgotten Change-Id it has a a faulty 
error-handling above...

-- 
Best regards,
Alexander Sverdlin.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/