Re: [PATCH 4/4] mtd: rawnand: cadence: reinit complete before execute command

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Hi Piotr,

Piotr Sroka <piotrs@xxxxxxxxxxx> wrote on Mon, 10 Feb 2020 10:55:28
+0100:

> Reinitilaize complete object before executing CDMA command to make sure
> that done flag is ok.

Looks fine, besides the need for Fixes/Stable tags, what do you think?

> 
> Signed-off-by: Piotr Sroka <piotrs@xxxxxxxxxxx>
> ---
>  drivers/mtd/nand/raw/cadence-nand-controller.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/nand/raw/cadence-nand-controller.c b/drivers/mtd/nand/raw/cadence-nand-controller.c
> index 5c1bbb05ab51..efddc5c68afb 100644
> --- a/drivers/mtd/nand/raw/cadence-nand-controller.c
> +++ b/drivers/mtd/nand/raw/cadence-nand-controller.c
> @@ -998,6 +998,7 @@ static int cadence_nand_cdma_send(struct cdns_nand_ctrl *cdns_ctrl,
>  		return status;
>  
>  	cadence_nand_reset_irq(cdns_ctrl);
> +	reinit_completion(&cdns_ctrl->complete);
>  
>  	writel_relaxed((u32)cdns_ctrl->dma_cdma_desc,
>  		       cdns_ctrl->reg + CMD_REG2);

Thanks,
Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/