Re: [PATCH] mtd: core: allow mask_flags to be set for mtd_add_partition

[Bruno Pena <brunompena@xxxxxxxxx>]

Hi Rafał,

A possible use case is mentioned on the description "mask certain
flags for new partitions (e.g. to make them read-only)" - I believe
this answers your "why?" question.
As for your comment about usefulness, you are very well aware this
comes from the OpenWrt pull request 2535 [1] where this new argument
is used.
The only reason why the full patch was not sent here is because it
depends on OpenWrt specific code [2] [3] that is yet to be merged on
the kernel.
For this reason - and as requested on OpenWrt - I decided to submit an
enabler patch for the kernel exported API mtd_add_partition.

[1] https://github.com/openwrt/openwrt/pull/2535
[2] https://github.com/openwrt/openwrt/blob/master/target/linux/generic/pending-4.14/401-mtd-add-support-for-different-partition-parser-types.patch
[3] https://github.com/openwrt/openwrt/blob/master/target/linux/generic/pending-4.19/401-mtd-add-support-for-different-partition-parser-types.patch

Best regards,
Bruno Pena


On Wed, Feb 5, 2020 at 9:31 AM Rafał Miłecki <zajec5@xxxxxxxxx> wrote:
>
> Hi,
>
> On 26.11.2019 22:25, Bruno Pena wrote:
> > This patchs makes it possible to mask certain flags for new partitions (e.g. to make them read-only).
> > The change consists in the addition of a new argument "mask_flags" to "mtd_add_partition" that is passed on to the "allocate_partition".
>
> Your description answers "what?" but not "why?".
>
> This patch adds a new function argument that is never used. This seems
> quite pointless.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/