Re: [PATCH] mtd: hyperbus: Add proper error message for missing compatible

[Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>]

On 02/03/2020 10:55 AM, Dirk Behme wrote:

> In case the compatible "cypress,hyperflash" is not given
> output a proper error message. Do it the same way as some
> lines above.
> 
> Signed-off-by: Dirk Behme <dirk.behme@xxxxxxxxxxxx>
> ---
>  drivers/mtd/hyperbus/hyperbus-core.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/hyperbus/hyperbus-core.c b/drivers/mtd/hyperbus/hyperbus-core.c
> index 6af9ea34117d..61b0f686a6dc 100644
> --- a/drivers/mtd/hyperbus/hyperbus-core.c
> +++ b/drivers/mtd/hyperbus/hyperbus-core.c
> @@ -73,8 +73,10 @@ int hyperbus_register_device(struct hyperbus_device *hbdev)
>  
>  	np = hbdev->np;
>  	ctlr = hbdev->ctlr;
> -	if (!of_device_is_compatible(np, "cypress,hyperflash"))
> +	if (!of_device_is_compatible(np, "cypress,hyperflash")) {
> +		pr_err("hyperbus: 'cypress,hyperflash' compatible missing\n");

   Traditionally, the string prop values are enclosed in "", not ''.

MBR, Sergei

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/