On Tue, Nov 05, 2019 at 12:51:36AM +0800, John Garry wrote:
> Only ACPI firmware is supported.
There's no ACPI dependency though? If the driver only works with ACPI
I'd expect to see one with an || COMPILE_TEST like the architecture
dependency.
> @@ -0,0 +1,287 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * HiSilicon SPI NOR V3XX Flash Controller Driver for hi16xx chipsets
> + *
Please make the entire comment a C++ one for neatness.
> + * Copyright (c) 2019 HiSilicon Technologies Co., Ltd.
> + * Author: John Garry <john.garry@xxxxxxxxxx>
> + */
> +//#define DEBUG 1
Please remove this.
> +#define GLOBAL_CFG (0x100)
> +
> +#define BUS_CFG1 (0x200)
> +#define BUS_CFG2 (0x204)
> +#define BUS_FLASH_SIZE (0x210)
> +
> +#define VERSION (0x1f8)
These could use some namespacing, especially the last one - it seems
quite likely there'll be some collisions at some point.
> +#define HISI_SFC_V3XX_WAIT_TIMEOUT_US 1000000
> +#define HISI_SFC_V3XX_WAIT_POLL_INTERVAL_US 10
Plus if we've got these long prefixes here it'd be good to be
consistent.
> + if (IS_ALIGNED((uintptr_t)to, 4)) {
> + int words = len / 4;
> +
> + __ioread32_copy(to, host->regbase + CMD_DATABUF(0), words);
> +
> + len -= words * 4;
> + if (len) {
> + u32 val;
> +
> + val = __raw_readl(host->regbase + CMD_DATABUF(words));
> +
> + to += words * 4;
> + for (i = 0; i < len; i++, val >>= 8, to++)
> + *to = (u8)val;
> + }
> + } else {
> + for (i = 0; i < DIV_ROUND_UP(len, 4); i++) {
> + u32 val = __raw_readl(host->regbase + CMD_DATABUF(i));
> + int j;
The more usual pattern for these would be to do some unaligned accesses
for the start/end of the buffer to get to alignment and then transfer
the rest as aligned data.
Attachment:
signature.asc
Description: PGP signature
______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
