Re: [PATCH] mtd: rawnand: brcmnand: Fix sparse warning in has_flash_dma()

[Florian Fainelli <f.fainelli@xxxxxxxxx>]

On 10/19/19 2:39 AM, Miquel Raynal wrote:
> Hi Florian,
> 
> Florian Fainelli <f.fainelli@xxxxxxxxx> wrote on Fri, 18 Oct 2019
> 16:38:44 -0700:
> 
>> Sparse rightfully complained about has_flash_dma():
>> +drivers/mtd/nand/brcmnand/brcmnand.c:951:40: warning: Using plain integer as NULL pointer [sparse]
> 
> I don't get why would sparse complain about this... Anyway I prefer
> the !!(<pointer>) alternative if you don't mind. Otherwise the "!=
> NULL" comparison feels wrong.

I did not read the sparse complaint correctly and mixed up two issues
(one downstream, one upstream) there is still one that is legitimately
reported by sparse and that will be fixed in a v2, thanks.
-- 
Florian

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/