Re: [PATCH] mtd: spi-nor: fix silent truncation in spi_nor_read()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

On 16.10.2019 8:18, Vignesh Raghavendra wrote:

spi_nor_read() assigns the result of 'ssize_t spi_nor_read_data()' to
an 'int ret' variable, where the silent truncation isn't really valid --
ssize_t is a 64-bit type and *int* is a 32-bit type on 64-bit machines.


Good catch! Curious to know if you did observe any real issue because of
this bug?

   No, found it just looking at the code.

Regards
Vignesh

Fixes: 59451e1233bd ("mtd: spi-nor: change return value of read/write")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>

[...]

MBR, Sergei

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/



[Index of Archives]     [LARTC]     [Bugtraq]     [Yosemite Forum]     [Photo]

  Powered by Linux