Re: [PATCH 2/2] mtd: physmap_of: add a hook for Intel IXP4xx flash probing

[Miquel Raynal <miquel.raynal@xxxxxxxxxxx>]

Hi Linus,

Linus Walleij <linus.walleij@xxxxxxxxxx> wrote on Fri,  1 Feb 2019
11:04:21 +0100:

> In order to support device tree probing of IXP4xx NOR flash
> chips, a certain big-endian or mixed-endian memory access
> pattern need to be used.
> 
> I have opted to use the pattern set by previous plug-ins
> to physmap for Gemini and Versatile, just override some
> functions and reuse most of the physmap core code as it
> is to minimize maintenance.
> 
> Parts of drivers/mtd/ixp4xx.c are copied into this file.
> 
> After we have IXP4xx converted fully to device tree, the
> drivers/mtd/ixp4xx.c file will be deleted and this will
> be the only access pattern to the IXP4xx flash.
> 
> I did not keep the quirk in the flash write function
> after probe, where the old code for a while checks for
> access to odd addresses, fails and assigns a "faster"
> write function once it has convinced probe to only use
> 2-byte accesses. As we mandate that this device should
> be using bank-width = <2> this should not be a problem
> unless misconfigured.
> 
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

I am checking what's in our patchwork for ages and I found this, can
you rebase on a recent version and if all this still applies can you
resend?

Thanks and sorry for the inconvenience.

Miquèl

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/