Hello!
On 09/17/2019 10:43 PM, Geert Uytterhoeven wrote:
>> cfi_udelay() open-codes DIV_ROUND_UP(), violating the kernel coding style
>
> Perhaps "violating" sounds a bit too harsh?
Hm, indeed, scripts/checkpatch.pl doesn't complain on this line. Do you have
other ideas how to call this? Or just omit this?
>> while doing this...
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
TY!
> Gr{oetje,eeting}s,
>
> Geert
MBR, Sergei
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
Re: [PATCH] mtd: cfi_util: use DIV_ROUND_UP() in cfi_udelay()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] mtd: cfi_util: use DIV_ROUND_UP() in cfi_udelay()
- From: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
- Date: Tue, 17 Sep 2019 22:53:45 +0300
- Cc: Vignesh Raghavendra <vigneshr@xxxxxx>, Richard Weinberger <richard@xxxxxx>, Marek Vasut <marek.vasut@xxxxxxxxx>, MTD Maling List <linux-mtd@xxxxxxxxxxxxxxxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Brian Norris <computersforpeace@xxxxxxxxx>, David Woodhouse <dwmw2@xxxxxxxxxxxxx>
- In-reply-to: <CAMuHMdVdKgBYSGJemH2LP+N61T+uui0XX1Zb-=dM5sNEAaQoMg@mail.gmail.com>
- Organization: Cogent Embedded
- References: <610761cf-5a19-c182-07d8-8d118ca20035@cogentembedded.com> <bd64fb56-c42d-7f7b-c6f1-4d7b43a6d191@cogentembedded.com> <CAMuHMdVdKgBYSGJemH2LP+N61T+uui0XX1Zb-=dM5sNEAaQoMg@mail.gmail.com>
- User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1
- Follow-Ups:
- Re: [PATCH] mtd: cfi_util: use DIV_ROUND_UP() in cfi_udelay()
- From: Geert Uytterhoeven
- Re: [PATCH] mtd: cfi_util: use DIV_ROUND_UP() in cfi_udelay()
- References:
- [PATCH 0/2] Untangle Spansion S25F{L|S}512S chip IDs
- From: Sergei Shtylyov
- [PATCH] mtd: cfi_util: use DIV_ROUND_UP() in cfi_udelay()
- From: Sergei Shtylyov
- Re: [PATCH] mtd: cfi_util: use DIV_ROUND_UP() in cfi_udelay()
- From: Geert Uytterhoeven
- [PATCH 0/2] Untangle Spansion S25F{L|S}512S chip IDs
- Prev by Date: Re: [PATCH] mtd: cfi_util: use DIV_ROUND_UP() in cfi_udelay()
- Next by Date: Re: [PATCH] mtd: cfi_util: use DIV_ROUND_UP() in cfi_udelay()
- Previous by thread: Re: [PATCH] mtd: cfi_util: use DIV_ROUND_UP() in cfi_udelay()
- Next by thread: Re: [PATCH] mtd: cfi_util: use DIV_ROUND_UP() in cfi_udelay()
- Index(es):
 |