Hi, On 21/08/19 3:06 PM, Shih-Ting Lin wrote: > > Winbond SPI NOR Flash have new product for 1.8V production line. > Following is the patch add new device ID and part number information in spi-nor.c file. > $subject should start with "mtd: spi-nor:" (run git log on the file to know pattern for the subsystem). How the patch was tested and what modes of the flash was tested should be part of commit msg. > Signed-off-by: ST Lin <stlin2@xxxxxxxxxxx> > Signed-off-by should be full name. Please follow steps in [1] for submitting patch Also run scripts/checkpatch.pl --strict and fix issues reported before sending. Please use git format-patch and git send-email to generate and send patches [1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html Regards Vignesh > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -2153,6 +2153,22 @@ > { "w25q256", INFO(0xef4019, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) }, > { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024, > SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) }, > +{ "w25q32jwxxIM", INFO(0xef8016, 0, 64 * 1024, 64, > +SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > +SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) > +}, > +{ "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128, > +SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > +SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) > +}, > +{ "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256, > +SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > +SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) > +}, > +{ "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512, > +SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | > +SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) > +}, > > /* Catalyst / On Semiconductor -- non-JEDEC */ > { "cat25c11", CAT25_INFO( 16, 8, 16, 1, SPI_NOR_NO_ERASE | SPI_NOR_NO_FR) }, > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ > > > ________________________________ > > The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Winbond is strictly prohibited; and any information in this email irrelevant to the official business of Winbond shall be deemed as neither given nor endorsed by Winbond. > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ > -- Regards Vignesh ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/