On 08/15/2019 11:32 AM, Dan Carpenter wrote: > External E-Mail > > > The problem is that if "ret" is negative then when we check if > "ret > len", that condition is going to be true because of type > promotion. So this patch re-orders the code to check for negatives > first and preserve those error codes. > > Fixes: f384b352cbf0 ("mtd: spi-nor: parse Serial Flash Discoverable Parameters (SFDP) tables") > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > drivers/mtd/spi-nor/spi-nor.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Since the bug was not introduced in the previous release and we are quite late for mtd/fixes, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git, spi-nor/next branch. Thanks, ta ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/