Hi Sascha, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.3-rc4 next-20190814] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sascha-Hauer/Add-quota-support-to-UBIFS/20190815-010732 config: i386-randconfig-a002-201932 (attached as .config) compiler: gcc-7 (Debian 7.4.0-10) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> Note: it may well be a FALSE warning. FWIW you are at least aware of it now. http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings All warnings (new ones prefixed by >>): fs/quota/quota.c: In function 'quotactl_get_super': fs/quota/quota.c:838:13: error: implicit declaration of function 'quotactl_cmd_write'; did you mean 'quotactl_cmd_onoff'? [-Werror=implicit-function-declaration] } else if (quotactl_cmd_write(cmd)) { ^~~~~~~~~~~~~~~~~~ quotactl_cmd_onoff fs/quota/quota.c: In function 'kernel_quotactl': >> fs/quota/quota.c:853:7: warning: 'exclusive' may be used uninitialized in this function [-Wmaybe-uninitialized] if (exclusive) ^ fs/quota/quota.c:832:23: note: 'exclusive' was declared here bool thawed = false, exclusive; ^~~~~~~~~ cc1: some warnings being treated as errors vim +/exclusive +853 fs/quota/quota.c ab9c4e200cc992 fs/quota/quota.c Sascha Hauer 2019-08-14 824 ^1da177e4c3f41 fs/quota.c Linus Torvalds 2005-04-16 825 /* 9361401eb7619c fs/quota.c David Howells 2006-09-30 826 * look up a superblock on which quota ops will be performed 9361401eb7619c fs/quota.c David Howells 2006-09-30 827 * - use the name of a block device to find the superblock thereon 9361401eb7619c fs/quota.c David Howells 2006-09-30 828 */ ab9c4e200cc992 fs/quota/quota.c Sascha Hauer 2019-08-14 829 static struct super_block *quotactl_get_super(const char __user *special, int cmd) 9361401eb7619c fs/quota.c David Howells 2006-09-30 830 { 9361401eb7619c fs/quota.c David Howells 2006-09-30 831 struct super_block *sb; 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 832 bool thawed = false, exclusive; 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 833 int ret; 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 834 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 835 if (quotactl_cmd_onoff(cmd)) { 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 836 thawed = true; 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 837 exclusive = true; 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 @838 } else if (quotactl_cmd_write(cmd)) { 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 839 thawed = true; 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 840 exclusive = false; 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 841 } 9361401eb7619c fs/quota.c David Howells 2006-09-30 842 ab9c4e200cc992 fs/quota/quota.c Sascha Hauer 2019-08-14 843 sb = quotactl_block(special); ab9c4e200cc992 fs/quota/quota.c Sascha Hauer 2019-08-14 844 if (IS_ERR(sb)) { ab9c4e200cc992 fs/quota/quota.c Sascha Hauer 2019-08-14 845 sb = quotactl_path(special); ab9c4e200cc992 fs/quota/quota.c Sascha Hauer 2019-08-14 846 if (IS_ERR(sb)) ab9c4e200cc992 fs/quota/quota.c Sascha Hauer 2019-08-14 847 return ERR_CAST(sb); ab9c4e200cc992 fs/quota/quota.c Sascha Hauer 2019-08-14 848 } 9361401eb7619c fs/quota.c David Howells 2006-09-30 849 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 850 if (thawed) { 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 851 ret = wait_super_thawed(sb, exclusive); 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 852 if (ret) { 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 @853 if (exclusive) 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 854 drop_super_exclusive(sb); 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 855 else 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 856 drop_super(sb); 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 857 return ERR_PTR(ret); 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 858 } 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 859 } 335508f54c9cd0 fs/quota/quota.c Sascha Hauer 2019-08-14 860 9361401eb7619c fs/quota.c David Howells 2006-09-30 861 return sb; 9361401eb7619c fs/quota.c David Howells 2006-09-30 862 } 9361401eb7619c fs/quota.c David Howells 2006-09-30 863 :::::: The code at line 853 was first introduced by commit :::::: 335508f54c9cd0c8589271420bee8a38cff13ed5 fs, quota: introduce wait_super_thawed() to wait until a superblock is thawed :::::: TO: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> :::::: CC: 0day robot <lkp@xxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
