Re: [PATCH] ubifs: Correctly initialize c->min_log_bytes

[Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>]

Hello Richard,

On Wed, Jul 31, 2019 at 10:07:06AM +0200, Richard Weinberger wrote:
> > On Thu, Jul 25, 2019 at 10:56:27PM +0200, Richard Weinberger wrote:
> >> Currently on a freshly mounted UBIFS, c->min_log_bytes is 0.
> >> This can lead to a log overrun and make commits fail.
> >> 
> >> Recent kernels will report the following assert:
> >> UBIFS assert failed: c->lhead_lnum != c->ltail_lnum, in fs/ubifs/log.c:412
> >> 
> >> c->min_log_bytes can have two states, 0 and c->leb_size.
> >> It controls how much bytes of the log area are reserved for non-bud
> >> nodes such as commit nodes.
> >> 
> >> After a commit it has to be set to c->leb_size such that we have always
> >> enought space for a commit. While a commit runs it can be 0 to make the
> >> remaining bytes of the log available to writers.
> >> 
> >> Having it set to 0 right after mount is wrong since no space for commits
> >> is reserved.
> >> 
> >> Reported-and-tested-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
> >> Signed-off-by: Richard Weinberger <richard@xxxxxx>
> > 
> > I assume you care for applying this to mainline? I wonder it isn't in
> > next yet?!
> 
> Don't stress me. The issue is present in UBIFS since day 0, there is absolutely
> no reason to hurry.
> It will get merged when I'm back from traveling and my time permits it.

My intention was not to stess you, just to ensure this is eventually
taken care of and to check if there is a blocker that I can help to
remove.

Thanks
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/