Re: [PATCH] mtd: rawnand: tango: Add of_node_put() before return

[Måns Rullgård <mans@xxxxxxxxx>]

Nishka Dasgupta <nishkadg.linux@xxxxxxxxx> writes:

> Each iteration of for_each_child_of_node puts the previous node, but in
> the case of a return from the middle of the loop, there is no put, thus
> causing a memory leak. Hence add an of_node_put before the return.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@xxxxxxxxx>
> ---
>  drivers/mtd/nand/raw/tango_nand.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/nand/raw/tango_nand.c b/drivers/mtd/nand/raw/tango_nand.c
> index b3f2cabcc7c0..9acf2de37ee0 100644
> --- a/drivers/mtd/nand/raw/tango_nand.c
> +++ b/drivers/mtd/nand/raw/tango_nand.c
> @@ -659,6 +659,7 @@ static int tango_nand_probe(struct platform_device *pdev)
>  		err = chip_init(&pdev->dev, np);
>  		if (err) {
>  			tango_nand_remove(pdev);
> +			of_node_put(np);
>  			return err;
>  		}
>  	}
> -- 

Acked-by: Mans Rullgard <mans@xxxxxxxxx>

-- 
Måns Rullgård

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/