Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips

[Schrempf Frieder <frieder.schrempf@xxxxxxxxxx>]

On 24.06.19 14:15, liaoweixiong wrote:
> In case of the last page containing bitflips (ret > 0),
> spinand_mtd_read() will return that number of bitflips for the last
> page. But to me it looks like it should instead return max_bitflips like
> it does when the last page read returns with 0.
> 
> Signed-off-by: liaoweixiong <liaoweixiong@xxxxxxxxxxxxxxxxx>
> Acked-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> Acked-by: Frieder Schrempf <frieder.schrempf@xxxxxxxxxx>

Why did you change our Reviewed-by tags to Acked-by tags?

> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs")
> ---
>   drivers/mtd/nand/spi/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c
> index 556bfdb..6b9388d 100644
> --- a/drivers/mtd/nand/spi/core.c
> +++ b/drivers/mtd/nand/spi/core.c
> @@ -511,12 +511,12 @@ static int spinand_mtd_read(struct mtd_info *mtd, loff_t from,
>   		if (ret == -EBADMSG) {
>   			ecc_failed = true;
>   			mtd->ecc_stats.failed++;
> -			ret = 0;
>   		} else {
>   			mtd->ecc_stats.corrected += ret;
>   			max_bitflips = max_t(unsigned int, max_bitflips, ret);
>   		}
>   
> +		ret = 0;
>   		ops->retlen += iter.req.datalen;
>   		ops->oobretlen += iter.req.ooblen;
>   	}
> 
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/