RE: [PATCH v2 2/2] arm64: defconfig: Enable access to CFI-compliant memory mapped NOR flash

[Leo Li <leoyang.li@xxxxxxx>]

> -----Original Message-----
> From: Jagdish Gediya <jagdish.gediya@xxxxxxx>
> Sent: Tuesday, May 7, 2019 7:16 AM
> To: linux-mtd@xxxxxxxxxxxxxxxxxxx
> Cc: bbrezillon@xxxxxxxxxx; Leo Li <leoyang.li@xxxxxxx>; Prabhakar
> Kushwaha <prabhakar.kushwaha@xxxxxxx>; Jagdish Gediya
> <jagdish.gediya@xxxxxxx>
> Subject: [PATCH v2 2/2] arm64: defconfig: Enable access to CFI-compliant
> memory mapped NOR flash

This should be sent to arm mailing list and arm maintainers(added for you), and cc the MTD owners.

> 
> Enable below configs in arm64 defconfig file,
> CONFIG_MTD_CFI=y
> CONFIG_MTD_CFI_INTELEXT=y
> CONFIG_MTD_CFI_AMDSTD=y
> CONFIG_MTD_CFI_STAA=y
> CONFIG_MTD_PHYSMAP=y
> CONFIG_MTD_PHYSMAP_OF=y

This include both CFI and PHYSMAP changes, and probably better to be separate.  And it will be good to mention that CONFIG_MTD_PHYSMAP_OF has been enabled previously in the defconfig.  It is because of the following change to the driver that it is no longer selectable alone but need CONFIG_MTD_PHYSMAP to be selectable.

commit 642b1e8dbed7bbbf8c4deb3c9a0496f17278badc
Author: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>
Date:   Fri Oct 19 09:49:04 2018 +0200

    mtd: maps: Merge physmap_of.c into physmap-core.c

    There's no real reason to have two separate driver for the DT and pdata
    case. Just do what we do everywhere else and handle DT and pdata
    parsing in the same driver.

    Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>
    Reviewed-by: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx>
    Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

> 
> These configs are needed to access CFI compliant memory mapped NOR
> flashes e.g. NOR flash connected over Freescale IFC.
> 
> Signed-off-by: Jagdish Gediya <jagdish.gediya@xxxxxxx>
> ---
> Change since v2:
>  Split the defconfig changes between,
>  1. Changes as a result of 'make savedefconfig' command
>  2. Enablement of actually needed configs
> 
>  arch/arm64/configs/defconfig | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index aff014e..ac06501 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -193,6 +193,12 @@ CONFIG_HISILICON_LPC=y
>  CONFIG_SIMPLE_PM_BUS=y
>  CONFIG_MTD=y
>  CONFIG_MTD_BLOCK=y
> +CONFIG_MTD_CFI=y
> +CONFIG_MTD_CFI_INTELEXT=y
> +CONFIG_MTD_CFI_AMDSTD=y
> +CONFIG_MTD_CFI_STAA=y
> +CONFIG_MTD_PHYSMAP=y
> +CONFIG_MTD_PHYSMAP_OF=y
>  CONFIG_MTD_M25P80=y
>  CONFIG_MTD_NAND=y
>  CONFIG_MTD_NAND_DENALI_DT=y
> --
> 2.7.4


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/