Re: [PATCH] mtd: cfi_util: mark expected switch fall-throughs

["Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx>]

On 3/20/19 4:05 PM, Richard Weinberger wrote:
> Hi!
> 
> Am Mittwoch, 20. März 2019, 21:20:51 CET schrieb Gustavo A. R. Silva:
>> Hi all,
>>
>> Friendly ping:
>>
>> Who can take this?
> 
> Hmmm, for MTD I think we can schedule these patches for the next merge window.
> But I'm not sure whether these comments are a good solution.
> I much more prefer the compiler attribute solution.
> Also a tree-wide (sane) coccinelle script would be better IMHO,
> and not zillions of individual patches via different trees.
> 

If that script is sophisticated enough to spot both false positives and
actual bugs, then yeah, I'd love that solution.  But it's actually not
that simple.

The thing about the compiler attributes is not a big deal, once we
finally enable -Wimplicit-fallthrough, for which we first need to
address each one of these cases.  But we are getting close, there
are less than 100 of these issues in linux-next. :)

So, if this is too much of a burden for people, I can add all these
MTD patches to my own tree for 5.2.

Just, please, let me know.

Thanks
--
Gustavo

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/