Re: [RFC PATCH 03/27] mtd: nand: Introduce the ECC engine abstraction

[Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>]

On Wed, 27 Feb 2019 10:26:42 +0100
Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:

> >   
> > > +	unsigned int strength;
> > > +	unsigned int step_size;
> > > +	unsigned int total;    
> > 
> > Do we really need to add this total field here? Looks like something
> > that should be kept private to the ECC engine implementation.  
> 
> It was initially private, but I realized it was needed by generic parts
> (including for instance the generic OOB layouts) so it could not be
> made private.
> 
> I just moved the 'total' entry out of the struct nand_ecc_conf and
> moved it in the struct nand_ecc_ctx. It is still public but not in the
> very generic "conf" structure anymore.

Ack.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/