Re: [RFC PATCH 14/27] mtd: nand: ecc: Turn the software Hamming implementation generic

[Boris Brezillon <bbrezillon@xxxxxxxxxx>]

On Thu, 21 Feb 2019 13:57:53 +0100
Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:


> -/*
> - * Detect and correct a 1 bit error for 256/512 byte block
> - */
> -int nand_correct_data(struct nand_chip *chip, u_char *dat, u_char *read_ecc,
> -		      u_char *calc_ecc);
> +int __ecc_sw_hamming_calculate(const unsigned char *buf,

Let's stop with these __ prefixes. Just prefix functions taking a
nand_device object with nand_ and leave others with the ecc_ prefix.

> +			       unsigned int step_size,
> +			       unsigned char *code, bool sm_order);
> +int ecc_sw_hamming_calculate(struct nand_device *nand,
> +			     const unsigned char *buf,
> +			     unsigned char *code);

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/