Re: [PATCH] mtd: spi-nor: Add support for mx25u3235f

[<Tudor.Ambarus@xxxxxxxxxxxxx>]

Hi, Boris,

On 01/30/2019 06:11 AM, Ding Tao wrote:
> From: André Valentin <avalentin@xxxxxxxxxxx>
> 
> The mx25u3235f is found on the ZyXEL NBG6817 router, therefore
> add driver support for it so that we can upstream board support.
> 
> Minimal tested with u-boot tools fw_printenv/fw_setenv on GlobalScale
> ESPRESSObin v5 board.
> 
> [miyatsu@xxxxxx: Remove unnecessary white space.]

Would you please move this line between Andre's S-o-b and Ding's?

> Signed-off-by: André Valentin <avalentin@xxxxxxxxxxx>

Ding,
your change should be indicated between the last Signed-off-by header and yours,
see Documentation/process/submitting-patches.rst. Your Tested-by tag could have
been here too.

> Signed-off-by: Ding Tao <miyatsu@xxxxxx>

Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>

Andre and Hauke, we will take this version of the patch, because Ding has worked
on it too.

> ---
change log was nice to have here.

Cheers,
ta

>  drivers/mtd/spi-nor/spi-nor.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index 6e13bbd1aaa5..01ac2e4babaa 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -1836,6 +1836,8 @@ static const struct flash_info spi_nor_ids[] = {
>  	{ "mx25l3255e",  INFO(0xc29e16, 0, 64 * 1024,  64, SECT_4K) },
>  	{ "mx25l6405d",  INFO(0xc22017, 0, 64 * 1024, 128, SECT_4K) },
>  	{ "mx25u2033e",  INFO(0xc22532, 0, 64 * 1024,   4, SECT_4K) },
> +	{ "mx25u3235f",	 INFO(0xc22536, 0, 64 * 1024,  64,
> +			 SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>  	{ "mx25u4035",   INFO(0xc22533, 0, 64 * 1024,   8, SECT_4K) },
>  	{ "mx25u8035",   INFO(0xc22534, 0, 64 * 1024,  16, SECT_4K) },
>  	{ "mx25u6435f",  INFO(0xc22537, 0, 64 * 1024, 128, SECT_4K) },
> 
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/