Re: PATCH: s25fl128s

[Marek Vasut <marek.vasut@xxxxxxxxx>]

On 1/30/19 8:51 AM, A. Celenk wrote:
> Hello Marek,

Hi,

> In spi-nor.c, Spansion s25fl128s shall be seperated into s25fl128s0 and
> s25fl128s1;due to two different versions of the chip: S25FL128SAGBHI200
> and S25FL128SAGBHI210. Patch attached.
> 
> Related thread: https://community.cypress.com/message/183016#183016
> 
> Excuse me for the mailing style, I've checked out "how to commit to
> kernel" for a while, and seems it'll take lots of hours for me to patch
> just 2 lines. I hope this doesn't offend the pathcing rules so much.

Take the patch, apply to linux-next/master [1], then
$ git add -u
$ git commit -s
<write the commit message, e.g.:
mtd: spi-nor: Split something somehow

Blah blah description of the change ...

Signed-of-by:...
Cc: Boris <email address>
Cc: Marek <email address>

Save, exit

$ git format-patch -1 -o /tmp/
$ ./scripts/checkpatch.pl /tmp/000*patch
< fix checkpatch issues>
$ git send-email --annotate --to=linux-mtd@xxxxxxxxxxxxxxxxxxx -1 HEAD

That's roughly the process. You should follow it, because maintainers
are overloaded as they are already, and cannot fix up ever single one
patch. Please follow the process to make it easier for maintainers and
prevent burnouts, which can lead to unpleasant experiences while working
with upstream etc.

[1] https://www.kernel.org/doc/man-pages/linux-next.html

-- 
Best regards,
Marek Vasut

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/