Re: [PATCH] jffs2: check dstlen for jffs2_zlib_compress()

[Richard Weinberger <richard@xxxxxx>]

Am Montag, 21. Januar 2019, 09:59:10 CET schrieb yang.yang29@xxxxxxxxxx:
> Thanks for reply.
> But I think if (*dstlen < 2) is not good enough.

Not enough in terms of what?
My patch does what the commit message says, it fixes the out of bound access.
What do I miss?

> Because if  the length of data_in is equals to 2, the length of output compressed data is also 2.
> So there's no meaning to do all the compress calculates.
> 
> And I had do an experiment:
> If dstlen equals to 3, and data_in has 3 same bytes, the length of output compressed data will be 2. 
> Which means compress is effective.

This is a different issue and a possible further optimization.

Thanks,
//richard




______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/