Re: [PATCH v2] jffs2: put directories f->sem on a separate lockdep class

[Richard Weinberger <richard.weinberger@xxxxxxxxx>]

On Mon, Apr 30, 2018 at 12:32 PM Helmut Grohne <h.grohne@xxxxxxxxxx> wrote:
> +       /* Mirror lock class of inode->i_rwsem, see
> +        * lockdep_annotate_inode_mutex_key.
> +        */
> +       lockdep_set_class(&f->sem, S_ISDIR(inode->i_mode) ?
> +               &jffs2_inode_info_sem_dir_key : &jffs2_inode_info_sem_key);

Please use a plain if/else branch.
lockdep_set_class() uses the second parameter verbatim in its reports.

-- 
Thanks,
//richard

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/