Re: [RFC PATCH 01/34] mtd: spi-nor: Add a new hook to let part specific code tweak the config

[Boris Brezillon <boris.brezillon@xxxxxxxxxxx>]

On Fri, 7 Dec 2018 16:29:02 +0000
"Sverdlin, Alexander (Nokia - DE/Ulm)" <alexander.sverdlin@xxxxxxxxx>
wrote:

> >  static const struct flash_info *spi_nor_match_id(const char *name)
> >  {
> >  	const struct flash_info *id = spi_nor_ids;
> > @@ -3805,6 +3821,18 @@ int spi_nor_scan(struct spi_nor *nor, const char *name,
> >  	if (info->flags & SPI_NOR_NO_FR)
> >  		params.hwcaps.mask &= ~SNOR_HWCAPS_READ_FAST;
> >  
> > +	/*
> > +	 * Post SFDP fixups. Has to be called before spi_nor_setup() because
> > +	 * some fixups might modify params that are then used by
> > +	 * spi_nor_setup() to select the opcodes.
> > +	 */
> > +	ret = spi_nor_post_sfdp_fixups(nor, &params);
> > +	if (ret) {
> > +		dev_err(dev, "failed in the post-SFDP fixups (err %d)\n",
> > +			ret);  
> 
> You don't report an error in patch 34, I think there should be a consistent
> approach to this...

Patch 34 shouldn't have been part of this series :), but I agree, we
should be consistent.

> 
> > +		return ret;
> > +	}
> > +
> >  	/*
> >  	 * Configure the SPI memory:
> >  	 * - select op codes for (Fast) Read, Page Program and Sector Erase.
> >   
> 


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/