Re: [PATCH 1/2 v3] mtd: maps: Leave assigned complex mappings

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

On Sun, Dec 2, 2018 at 9:48 AM Boris Brezillon
<boris.brezillon@xxxxxxxxxxx> wrote:
> On Tue, 27 Nov 2018 21:53:57 +0100
> Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> > The simple_map_init() may need to be called with some
> > function pointers already assigned for complex mappings,
> > just bail out if complex handlers have already been
> > assigned.
>
> The commit message no longer matches what the patch does.
>
> How about:
>
> "
> mtd: maps: physmap: Leave assigned complex mappings
>
> SoC-specific drivers might provide their own map->xxx() implementation,
> and calling simple_map_init() unconditionally will override those
> implementations.
>
> Make sure map->read is NULL before calling simple_map_init().
> "
>
> If you're okay with this new commit message, I can fix it when applying.

Sure, go ahead Boris, thanks!

Yours,
Linus Walleij

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/