Re: [PATCH v2] mtd: spi-nor: Add Winbond w25q128jv support

[Robert Marko <robimarko@xxxxxxxxx>]

On Tue, 20 Nov 2018 at 16:28, <Tudor.Ambarus@xxxxxxxxxxxxx> wrote:
>
>
>
> On 06/25/2018 02:17 PM, Robert Marko wrote:
> > Datasheet:
> > http://www.winbond.com/resource-files/w25q128jv%20revf%2003272018%20plus.pdf
> >
> > Testing done on Mikrotik Routerboard  wAP R board.
> > It does not support Dual or Quad modes.
>
> But you have dual and quad read support.

Yes, I did not express myself clearly there.
Flash has support for both Dual and Quad modes, but the board it was
tested on does not.
>
> >
> > Signed-off-by: Robert Marko <robimarko@xxxxxxxxx>
>
> Apart of the observation above:
>
> Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>
>
> > ---
> >
> > Changes in v2:
> >       - Correct the title
> > ---
> >  drivers/mtd/spi-nor/spi-nor.c | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> > index d9c368c44194..3501dddc3167 100644
> > --- a/drivers/mtd/spi-nor/spi-nor.c
> > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > @@ -1239,6 +1239,11 @@ static const struct flash_info spi_nor_ids[] = {
> >                       SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> >                       SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> >       },
> > +     {
> > +             "w25q128jv", INFO(0xef7018, 0, 64 * 1024, 256,
> > +                     SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> > +                     SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> > +     },
> >       { "w25q80", INFO(0xef5014, 0, 64 * 1024,  16, SECT_4K) },
> >       { "w25q80bl", INFO(0xef4014, 0, 64 * 1024,  16, SECT_4K) },
> >       { "w25q128", INFO(0xef4018, 0, 64 * 1024, 256, SECT_4K) },
> >

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/