Re: [PATCH v3 1/2] mtd: spi-nor: Make sure SFDP-based 4B_OPCODE support detection works correctly

[Boris Brezillon <boris.brezillon@xxxxxxxxxxx>]

On Fri, 9 Nov 2018 09:57:13 +0000
<Tudor.Ambarus@xxxxxxxxxxxxx> wrote:

> >> When SNOR_F_4B_OPCODES comes from bfpt, addr_width is set to 4. For the id-based
> >> caps detection, when mtd->size > 0x1000000, we set nor->addr_width = 4 too.
> >>
> >> The only uncovered case would be when
> >>         } else if (info->addr_width) {
> >>                 nor->addr_width = info->addr_width;
> >>
> >> but this can be solved by reordering the else if cases.
> >>
> >>         if (nor->addr_width) {
> >>                 /* already configured from SFDP */
> >>         } else if (mtd->size > 0x1000000) {
> >> 		...
> >>         } else if (info->addr_width) {
> >>                 nor->addr_width = info->addr_width;
> >>         } else {
> >>                 nor->addr_width = 3;
> >>         }
> >>
> >> What do you think?  
> > 
> > I'd rather not change that in this patch, but feel free to propose
> > a patch on top of mine to simplify the logic if you think it's
> > needed.
> >   
> 
> yeah, it can be made in a separate patch.

If you're okay with the current version, can you add a R-b?

Thanks,

Boris

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/