Re: [PATCH] mtd: spi-nor: Set SPI_NOR_4B_OPCODES on all >16MB Spansion NORs

[Boris Brezillon <boris.brezillon@xxxxxxxxxxx>]

Hi Cyrille,

On Thu, 20 Sep 2018 16:28:43 +0200
Cyrille Pitchen <cyrille.pitchen@xxxxxxxxxx> wrote:

> Hi Boris,
> 
> Le 20/09/2018 à 16:14, Boris Brezillon a écrit :
> > The code was treating >16MB Spansion NORs as a special case, while they
> > could just be flagged with SPI_NOR_4B_OPCODES and be treated as other
> > NORs.
> > 
> > This change simplifies the code and makes it explicit that those parts
> > are supporting 4B addressing.
> > 
> > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>
> > ---
> > I've checked the datasheet of s25fl512s and s70fl01gs, and they indeed
> > support 4B opcodes. Other Spansion NORs might also support 4B opcodes,
> > but those that are not already have SPI_NOR_4B_OPCODES set are anyway
> > <16MB in size.
> > 
> > Also, I kept NOR definitions on a single line, since those were already
> > over 80chars. Marek, let me know if you want me to change that for the
> > GigaDevice formatting:
> > 
> >         {
> >                 "gd25q16", INFO(0xc84015, 0, 64 * 1024,  32,
> >                         SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> >                         SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> >         },
> > ---
> >  drivers/mtd/spi-nor/spi-nor.c | 9 +++------
> >  1 file changed, 3 insertions(+), 6 deletions(-)
> > 
> > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> > index 7993dd5c0c21..391e888758c1 100644
> > --- a/drivers/mtd/spi-nor/spi-nor.c
> > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > @@ -1416,8 +1416,8 @@ static const struct flash_info spi_nor_ids[] = {
> >  	{ "s25sl064p",  INFO(0x010216, 0x4d00,  64 * 1024, 128, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> >  	{ "s25fl256s0", INFO(0x010219, 0x4d00, 256 * 1024, 128, USE_CLSR) },
> >  	{ "s25fl256s1", INFO(0x010219, 0x4d01,  64 * 1024, 512, SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ | USE_CLSR) },  
> 
> You need to add the SPI_NOR_4B_OPCODES to all Spansion/Cypress memory
> parts > 128Mbits, hence also to 256Mbits memory parts ;)

Crap! I missed those ones. Will fix it in a v2.

Thanks,

Boris

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/